Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conntrack-sync: T6057: Add ability to disable syslog for conntrackd #3099

Merged
merged 1 commit into from Mar 6, 2024

Conversation

natali-rs1985
Copy link
Contributor

Change Summary

Ability to disable syslog for conntrackd

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

vyos/vyos-documentation#1312

Component(s) name

conntrack-sync

Proposed changes

Ability to disable syslog for conntrackd

How to test

set high-availability vrrp group internal address 10.0.0.10 interface 'eth0'
set high-availability vrrp group internal interface 'eth0'
set high-availability vrrp group internal vrid '36'
set high-availability vrrp sync-group syncgrp member 'internal'
set service conntrack-sync failover-mechanism vrrp sync-group 'syncgrp'
set service conntrack-sync interface eth0
set service conntrack-sync disable-syslog
commit

Expected result:

vyos@vyos:~$ cat /run/conntrackd/conntrackd.conf | grep Syslog
    Syslog off

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team March 6, 2024 17:38
Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-po c-po merged commit 836adb8 into vyos:current Mar 6, 2024
8 checks passed
@c-po
Copy link
Member

c-po commented Mar 6, 2024

@Mergifyio backport sagitta

Copy link

mergify bot commented Mar 6, 2024

backport sagitta

✅ Backports have been created

c-po added a commit that referenced this pull request Mar 6, 2024
conntrack-sync: T6057: Add ability to disable syslog for conntrackd (backport #3099)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants