Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ethernet: T5566: disable energy efficient ethernet (EEE) for interfaces" #3177

Merged
merged 1 commit into from Mar 24, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Mar 24, 2024

Change Summary

This reverts commit ab30509.

As in T6152 there seem to be some NICs that have a non working implementation of reading the EEE registers. Remove this feature in the meantime until there is a less exploding solution hindering boards to boot.

Return to Kernel defaults by removing this code path.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): remove EEE disable functionality

Related Task(s)

Related PR(s)

Component(s) name

Ethernet driver

Proposed changes

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

…interfaces"

This reverts commit ab30509.

As in T6152 there seem to be some NICs that have a non working implementation
of reading the EEE registers. Remove this feature in the meantime until there
is a less exploding solution hindering boards to boot.

Return to Kernel defaults by removing this code path.
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team March 24, 2024 08:31
@c-po
Copy link
Member Author

c-po commented Mar 24, 2024

@Mergifyio backport sagitta

@c-po c-po merged commit d69ad85 into vyos:current Mar 24, 2024
6 of 7 checks passed
Copy link

mergify bot commented Mar 24, 2024

backport sagitta

✅ Backports have been created

@c-po c-po deleted the eee-T6152 branch March 24, 2024 08:32
c-po added a commit that referenced this pull request Mar 24, 2024
Revert "ethernet: T5566: disable energy efficient ethernet (EEE) for interfaces" (backport #3177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant