Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grub: T6165: increase service TimeoutSec from 5 -> 60 #3179

Merged
merged 1 commit into from Mar 24, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Mar 24, 2024

Change Summary

The PCEngines APU2 systems with mSATA disks tend to be very slow. This results in a service startup error:

$ systemctl status vyos-grub-update
× vyos-grub-update.service - Update GRUB loader configuration structure
     Loaded: loaded (/lib/systemd/system/vyos-grub-update.service; enabled; preset: enabled)
     Active: failed (Result: timeout) since Sun 2024-03-24 08:48:10 UTC; 14min ago
   Main PID: 779 (code=killed, signal=TERM)
        CPU: 869ms

Mar 24 08:48:05 LR4.wue3 systemd[1]: Starting vyos-grub-update.service - Update GRUB loader configuration structure...
Mar 24 08:48:10 LR4.wue3 systemd[1]: vyos-grub-update.service: start operation timed out. Terminating.
Mar 24 08:48:10 LR4.wue3 systemd[1]: vyos-grub-update.service: Main process exited, code=killed, status=15/TERM
Mar 24 08:48:10 LR4.wue3 systemd[1]: vyos-grub-update.service: Failed with result 'timeout'.
Mar 24 08:48:10 LR4.wue3 systemd[1]: Failed to start vyos-grub-update.service - Update GRUB loader configuration structure.

Measunring on an APU2 system after boot and memory is "hot", it still needs almost 17 seconds to complete the job

cpo@LR4.wue3:~$ time sudo /usr/libexec/vyos/system/grub_update.py
real    0m16.803s
user    0m0.018s
sys     0m0.028s

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

vyos-grub-update.service

Proposed changes

Increase startup timeout

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team March 24, 2024 09:19
@c-po
Copy link
Member Author

c-po commented Mar 24, 2024

@Mergifyio backport sagitta

Copy link

mergify bot commented Mar 24, 2024

backport sagitta

✅ Backports have been created

The PCEngines APU2 systems with mSATA disks tend to be very slow. This results
in a service startup error:

$ systemctl status vyos-grub-update
× vyos-grub-update.service - Update GRUB loader configuration structure
     Loaded: loaded (/lib/systemd/system/vyos-grub-update.service; enabled; preset: enabled)
     Active: failed (Result: timeout) since Sun 2024-03-24 08:48:10 UTC; 14min ago
   Main PID: 779 (code=killed, signal=TERM)
        CPU: 869ms

Mar 24 08:48:05 LR4.wue3 systemd[1]: Starting vyos-grub-update.service - Update GRUB loader configuration structure...
Mar 24 08:48:10 LR4.wue3 systemd[1]: vyos-grub-update.service: start operation timed out. Terminating.
Mar 24 08:48:10 LR4.wue3 systemd[1]: vyos-grub-update.service: Main process exited, code=killed, status=15/TERM
Mar 24 08:48:10 LR4.wue3 systemd[1]: vyos-grub-update.service: Failed with result 'timeout'.
Mar 24 08:48:10 LR4.wue3 systemd[1]: Failed to start vyos-grub-update.service - Update GRUB loader configuration structure.

Measunring on an APU2 system after boot and memory is "hot", it still needs
almost 17 seconds to complete the job

cpo@LR4.wue3:~$ time sudo /usr/libexec/vyos/system/grub_update.py
real    0m16.803s
user    0m0.018s
sys     0m0.028s
@c-po c-po changed the title grub: T4516: increase service TimeoutSec from 5 -> 60 grub: T6165: increase service TimeoutSec from 5 -> 60 Mar 24, 2024
@jestabro jestabro merged commit afaf715 into vyos:current Mar 24, 2024
7 checks passed
c-po added a commit that referenced this pull request Mar 24, 2024
grub: T6165: increase service TimeoutSec from 5 -> 60 (backport #3179)
@c-po c-po deleted the grub-T6165 branch March 24, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants