image-tools: T6168: compat mode update should preserve console type #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyosbot
requested review from
a team,
dmbaturin,
sarthurdev,
zdc,
sever-sever and
c-po
and removed request for
a team
Add system image in compatibility mode would set the default boot without reference to console_type; fix the translation of default to the correct index in compat grub.cfg.
jestabro
force-pushed
the
compat-update-serial-console
branch
from
f0e40f5
to
1cb05f4
Compare
dmbaturin
approved these changes
Mar 27, 2024
|
Moved to draft while considering @c-po test case. |
|
A few related issues/bugs will be separate PRs under task https://vyos.dev/T6176. This one can proceed as is. |
c-po
approved these changes
Mar 28, 2024
|
@Mergifyio backport sagitta |
✅ Backports have been created
|
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
In compatibility mode, the 'default' index in grub.cfg was always the entry for 'tty' console type; fix to use correct entry for current console.
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: