Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ospf: T6089: fix invalid "ospf passive-interface default" #3249

Merged
merged 1 commit into from Apr 4, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Apr 4, 2024

Change Summary

The option "passive-interface default" was set even if it was not present in the previous version we are migrating from. Fix migration script to handle this with a conditional path.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

Conditional code path for default with a new config test added to check the migrator

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

The option "passive-interface default" was set even if it was not present in
the previous version we are migrating from. Fix migration script to handle this
with a conditional path.
@vyosbot vyosbot requested a review from a team April 4, 2024 19:01
@vyosbot vyosbot requested review from dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team April 4, 2024 19:01
@c-po
Copy link
Member Author

c-po commented Apr 4, 2024

@Mergifyio backport sagitta

Copy link

mergify bot commented Apr 4, 2024

backport sagitta

✅ Backports have been created

@c-po c-po merged commit 92a1c2c into vyos:current Apr 4, 2024
8 checks passed
dmbaturin added a commit that referenced this pull request Apr 4, 2024
ospf: T6089: fix invalid "ospf passive-interface default" (backport #3249)
@c-po c-po deleted the ospf-T6089 branch April 5, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants