Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcpv6-client: T2590: fix vyos-hostsd update for nameserver and search domains (backport #3224) #3250

Merged
merged 1 commit into from Apr 5, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Apr 4, 2024

Change Summary

After migrating from ISC DHCLIENT for IPv6 to wide-dhcp-client the logic which was present to update /etc/resolv.conf with the DHCP specified nameservers and also the search domain list was no longer present.

This commit adds a per interface rendered script to inform vyos-hostsd about the received IPv6 nameservers and search domains.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

wide-dhcp-client

Proposed changes

How to test

set interfaces ethernet eth0 address 'dhcpv6'
set system name-server 'eth0'
$ cat /etc/resolv.conf
### Autogenerated by VyOS ###
### Do not edit, your changes will get overwritten ###

# dhcpv6-eth0
nameserver 2001:db8::8888
nameserver 2001:db8::4444

# dhcpv6-eth0
search vyos.net.

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po added backport equuleus VyOS 1.3 LTS labels Apr 4, 2024
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team April 4, 2024 19:22
@c-po c-po changed the base branch from current to equuleus April 4, 2024 19:23
@c-po c-po removed the current label Apr 4, 2024
…h domains

After migrating from ISC DHCLIENT for IPv6 to wide-dhcp-client the logic which
was present to update /etc/resolv.conf with the DHCP specified nameservers and
also the search domain list was no longer present.

This commit adds a per interface rendered script to inform vyos-hostsd about
the received IPv6 nameservers and search domains.

(cherry picked from commit ece425f)
@c-po c-po merged commit d5750f0 into vyos:equuleus Apr 5, 2024
2 of 3 checks passed
@c-po c-po deleted the dhcpv6-T2590-equuleus branch April 5, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants