Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5872: fix ipsec dhclient hook uses "exit" instead of "return" #3302

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

lucasec
Copy link
Contributor

@lucasec lucasec commented Apr 12, 2024

Change Summary

This is a bug fix to #2965.
Because dhclient sources each exit hook instead of running it in a separate shell, we need to use return to bail out early, not exit.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team and dmbaturin and removed request for a team April 12, 2024 16:37
@vyosbot vyosbot requested review from sarthurdev and zdc April 12, 2024 16:37
@c-po c-po merged commit a8b8529 into vyos:current Apr 12, 2024
9 checks passed
@c-po
Copy link
Member

c-po commented Apr 12, 2024

@Mergifyio backport sagitta

Copy link

mergify bot commented Apr 12, 2024

backport sagitta

✅ Backports have been created

dmbaturin added a commit that referenced this pull request Apr 13, 2024
T5872: fix ipsec dhclient hook uses "exit" instead of "return" (backport #3302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants