Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect_disconnect: T6261: correction to typo in check_ppp_running #3347

Merged
merged 1 commit into from Apr 23, 2024

Conversation

Giggum
Copy link
Contributor

@Giggum Giggum commented Apr 23, 2024

Change Summary

Connect_disconnect: T6261: correction to typo in check_ppp_running function

Changes include:

  1. Replaces "beeing" -> being in print statement for check_ppp_running
  2. Replaces "can not" -> cannot in print statement on lines 61 and 93

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6261

Related PR(s)

Component(s) name

N/A

Proposed changes

N/A

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • [N/A] I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • [N/A] My change requires a change to the documentation
  • [N/A] I have updated the documentation accordingly

…nction

Connect_disconnect: T6261: correction to typo in check_ppp_running function

Changes include:
1. Replaces "beeing" -> being in print statement for check_ppp_running
2. Replaces "can not" -> cannot in print statement on lines 61 and 93
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team April 23, 2024 01:45
@c-po
Copy link
Member

c-po commented Apr 23, 2024

@Mergifyio backport sagitta

Copy link

mergify bot commented Apr 23, 2024

backport sagitta

✅ Backports have been created

@c-po c-po merged commit d7e0561 into vyos:current Apr 23, 2024
8 checks passed
@c-po
Copy link
Member

c-po commented Apr 23, 2024

@Mergifyio backport equuleus

Copy link

mergify bot commented Apr 23, 2024

backport equuleus

✅ Backports have been created

c-po added a commit that referenced this pull request Apr 23, 2024
connect_disconnect: T6261: correction to typo in check_ppp_running (backport #3347)
dmbaturin added a commit that referenced this pull request Apr 24, 2024
connect_disconnect: T6261: correction to typo in check_ppp_running (backport #3347)
@Giggum Giggum deleted the vyos-1x_T6261 branch May 3, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants