Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netns: T6295: disable incomplete support in VyOS 1.4 sagitta #3403

Merged
merged 1 commit into from
May 3, 2024
Merged

netns: T6295: disable incomplete support in VyOS 1.4 sagitta #3403

merged 1 commit into from
May 3, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented May 2, 2024 •
edited

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): remove feture

Related Task(s)

Component(s) name

  • netns

Proposed changes

How to test

Smoketest result

image

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
netns: T6295: disable incomplete support in VyOS 1.4 sagitta
dd40ed5 
The netns support currently available on the VyOS CLI is only a
proof-of-technology, we have no real support for any service behind it.

In order to not confuse anyone on the LTS branch we decided to remove the
netns option for interfaces until there is a proper usecase and implementation
available.
@c-po c-po requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team May 2, 2024 19:10
@c-po c-po self-assigned this May 2, 2024
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label May 2, 2024
@c-po c-po marked this pull request as ready for review May 2, 2024 20:25
@dmbaturin dmbaturin merged commit 1e36c2d into vyos:sagitta May 3, 2024
5 of 7 checks passed
@c-po c-po deleted the netns-removal branch May 26, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@jestabro jestabro jestabro approved these changes

@sever-sever sever-sever sever-sever approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
sagitta VyOS 1.4 LTS
Milestone
No milestone
4 participants
@c-po @dmbaturin @jestabro @sever-sever