Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webproxy: T6328: Add a warning message about deprecation of web proxy URL filtering #3439

Merged
merged 1 commit into from
May 10, 2024

Conversation

natali-rs1985
Copy link
Contributor

@natali-rs1985 natali-rs1985 commented May 10, 2024

Change Summary

Add a warning message about deprecation of web proxy URL filtering

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Deprecation warning

Related Task(s)

Related PR(s)

Component(s) name

service webproxy

Proposed changes

How to test

set service webproxy listen-address 192.168.122.14
set service webproxy url-filtering squidguard block-category 'ads'
commit

vyos@vyos# commit
[ service webproxy ]

WARNING: DB of category ads does not exist.
 Use [update webproxy blacklists] or delete undefined category!


DEPRECATION WARNING: URL filtering with SquidGuard is deprecated and
will be removed in the future VyOS versions.

Smoketest result

vyos@vyos# /usr/libexec/vyos/tests/smoke/cli/test_service_webproxy.py
test_01_basic_proxy (__main__.TestServiceWebProxy.test_01_basic_proxy) ... ok
test_02_advanced_proxy (__main__.TestServiceWebProxy.test_02_advanced_proxy) ... ok
test_03_ldap_proxy_auth (__main__.TestServiceWebProxy.test_03_ldap_proxy_auth) ... ok
test_04_cache_peer (__main__.TestServiceWebProxy.test_04_cache_peer) ... ok
test_05_basic_squidguard (__main__.TestServiceWebProxy.test_05_basic_squidguard) ... ok

----------------------------------------------------------------------
Ran 5 tests in 184.114s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label May 10, 2024
@c-po c-po requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team May 10, 2024 12:24
@c-po c-po merged commit 4960a67 into vyos:sagitta May 10, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
3 participants