ipoe: T2294: Fix templates and migrate to systemd #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That should habe been actually two commits as two independant changes. Could you split that please? |
|
Should I create subtask and cancel this PR? |
|
Nope, just split the vommit and keep the Taskid thats fine. Those might be related in a task way but not in the git way of doing coherent commits which only fix one thing at a time. that would be the template rendering and on the other habd systemd - two non related changes which deal witbthe greater good for T2294 |
DmitriyEshenko
force-pushed
the
fix-ipoe
branch
from
4ab3800
to
3c4e32e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.