Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conntrack: T6396: correction to helper message for ipv4/ipv6 custom timeout rule #3563

Merged
merged 1 commit into from
May 31, 2024

Conversation

Giggum
Copy link
Contributor

@Giggum Giggum commented May 31, 2024

Change Summary

The completion helper description for the inbound-interface is incorrect when specifying a custom conntrack timeout rule for both ipv4 and ipv6 timeout rules. This PR is to amend this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6396

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@Giggum
Copy link
Contributor Author

Giggum commented May 31, 2024

From VyOS Phabricator task description, this PR is to replace the current helper description of "Interface to ignore connections tracking on" below with "Interface to ignore connections tracking on" when setting custom conntrack timeout rules.

tim@ferrari# set system conntrack timeout custom ipv4 rule 10 
Possible completions:
   description          Description
 > destination          Destination parameters
   inbound-interface    Interface to ignore connections tracking on
 > protocol             Customize protocol specific timers, one protocol configuration
                        per rule
 > source               Source parameters

The constraintErrorMessage was also revised to refer to a "timeout" rule rather than an"ignore" rule.

These changes also apply to 1.4/Sagitta

@c-po c-po enabled auto-merge May 31, 2024 04:18
@c-po
Copy link
Member

c-po commented May 31, 2024

@Mergifyio backport sagitta

Copy link

mergify bot commented May 31, 2024

backport sagitta

✅ Backports have been created

@c-po c-po merged commit dccbc31 into vyos:current May 31, 2024
8 checks passed
c-po added a commit that referenced this pull request May 31, 2024
conntrack: T6396: correction to helper message for ipv4/ipv6 custom timeout rule (backport #3563)
@Giggum Giggum deleted the vyos_t6396 branch June 3, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants