Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firewall: T3900: T6394: remove unused import #3607

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Jun 9, 2024

Change Summary

With commit 770edf0 ("T3900: T6394: extend functionalities in firewall; move netfilter sysctl timeout parameters defined in conntrack to firewall global-opton section.") the import of the glob module is no longer required.

Found my running: make unused-imports

NOTE: No backport required as the introducing change is not (yet) part of 1.4.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

firewall

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

With commit 770edf0 ("T3900: T6394: extend functionalities in firewall;
move netfilter sysctl timeout parameters defined in conntrack to firewall
global-opton section.") the import of the glob module is no longer
required.

Found my running: make unused-imports
@c-po c-po requested a review from a team as a code owner June 9, 2024 07:38
@c-po c-po enabled auto-merge June 9, 2024 07:39
@c-po c-po merged commit 5320fa2 into vyos:current Jun 10, 2024
8 of 9 checks passed
@c-po c-po deleted the firewall-unused-import branch June 10, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants