Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firewall: T3900: fix migration and smoketests #3632

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

c-po
Copy link
Member

@c-po c-po commented Jun 11, 2024

Change Summary

Commit 770edf0 ("T3900: T6394: extend functionalities in firewall") changed the position in the CLI for conntrack timeout. This lead to failing smoketests because of a regression in the migrator.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

image

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Commit 770edf0 ("T3900: T6394: extend functionalities in firewall")
changed the position in the CLI for conntrack timeout. This lead to failing
smoketests because of a regression in the migrator.
Copy link

👍
No issues in PR Title / Commit Title

@c-po c-po merged commit dd813e5 into vyos:current Jun 11, 2024
8 checks passed
@sever-sever
Copy link
Member

@Mergifyio backport circinus-stream

Copy link

mergify bot commented Jun 11, 2024

backport circinus-stream

✅ Backports have been created

c-po added a commit that referenced this pull request Jun 11, 2024
firewall: T3900: fix migration and smoketests (backport #3632)
@c-po c-po deleted the fixup-firewall branch June 15, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants