Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-mode: T6503: "restart ssh" command not working #3702

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Jun 21, 2024

Change Summary

Commit e5af1f0 ("ssh: T6192: allow binding to multiple VRF instances") switched the systemd unit file from ssh.service to ssh@*.service, this change was not reflected in the "restart ssh" op-mode command.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

op-mode ssh

Proposed changes

How to test

See PID increasing

cpo@LR2.wue3:~$ ps faux | grep /usr/sbin/sshd
cpo         6381  0.0  0.2   6468  2048 pts/0    S+   22:53   0:00          \_ grep /usr/sbin/sshd
root        6375  0.0  0.9  15564  9344 ?        Ss   22:48   0:00 sshd: /usr/sbin/sshd -f /run/sshd/sshd_config [listener] 0 of 10-100 startups
cpo@LR2.wue3:~$ restart ssh
cpo@LR2.wue3:~$ ps faux | grep /usr/sbin/sshd
cpo         6431  0.0  0.2   6468  2048 pts/0    S+   22:53   0:00          \_ grep /usr/sbin/sshd
root        6429  0.0  0.9  15568  9472 ?        Ss   22:53   0:00 sshd: /usr/sbin/sshd -f /run/sshd/sshd_config [listener] 0 of 10-100 startups
cpo@LR2.wue3:~$ restart ssh
cpo@LR2.wue3:~$ ps faux | grep /usr/sbin/sshd
cpo         6457  0.0  0.2   6468  2176 pts/0    S+   22:53   0:00          \_ grep /usr/sbin/sshd
root        6454  0.0  0.9  15564  9472 ?        Ss   22:53   0:00 sshd: /usr/sbin/sshd -f /run/sshd/sshd_config [listener] 0 of 10-100 startups

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Jun 21, 2024

👍
No issues in PR Title / Commit Title

@c-po
Copy link
Member Author

c-po commented Jun 21, 2024

@Mergifyio backport sagitta circinus

Copy link

mergify bot commented Jun 21, 2024

backport sagitta circinus

✅ Backports have been created

@c-po c-po marked this pull request as draft June 21, 2024 20:33
Commit e5af1f0 ("ssh: T6192: allow binding to multiple VRF instances")
switched the systemd unit file from ssh.service to ssh@*.service, this change
was not reflected in the "restart ssh" op-mode command.
@c-po c-po marked this pull request as ready for review June 21, 2024 20:49
@c-po c-po enabled auto-merge June 22, 2024 04:44
@c-po c-po merged commit 4732b35 into vyos:current Jun 22, 2024
11 checks passed
c-po added a commit that referenced this pull request Jun 22, 2024
op-mode: T6503: "restart ssh" command not working (backport #3702)
c-po added a commit that referenced this pull request Jun 22, 2024
op-mode: T6503: "restart ssh" command not working (backport #3702)
@c-po c-po deleted the T6503-restart-ssh branch June 23, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants