ssh: T5878: Allow changing the PubkeyAcceptedAlgorithms option

[HollyGurza]

Change Summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

vyos@vyos:~$ python3 /usr/libexec/vyos/tests/smoke/cli/test_service_ssh.py 
test_ssh_default (__main__.TestServiceSSH.test_ssh_default) ... ok
test_ssh_dynamic_protection (__main__.TestServiceSSH.test_ssh_dynamic_protection) ... ok
test_ssh_login (__main__.TestServiceSSH.test_ssh_login) ... ok
test_ssh_multiple_listen_addresses (__main__.TestServiceSSH.test_ssh_multiple_listen_addresses) ... ok
test_ssh_ndcpp (__main__.TestServiceSSH.test_ssh_ndcpp) ... ok
test_ssh_pubkey_accepted_algorithm (__main__.TestServiceSSH.test_ssh_pubkey_accepted_algorithm) ... ok
test_ssh_single_listen_address (__main__.TestServiceSSH.test_ssh_single_listen_address) ... ok
test_ssh_vrf_multi (__main__.TestServiceSSH.test_ssh_vrf_multi) ... 
VRF "red" does not exist!

ok
test_ssh_vrf_single (__main__.TestServiceSSH.test_ssh_vrf_single) ... 
VRF "mgmt" does not exist!

ok

----------------------------------------------------------------------
Ran 9 tests in 41.441s

OK

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[dmbaturin]

Could you please correct the grammar in the commit message? I corrected in the PR title. I have no issues with the implementation.

[HollyGurza]

doc PR: vyos/vyos-documentation#1492

[dmbaturin]

All other SSH options (key exchange, cipher...) use explicit lists of values and don't allow excluding algorithms.

We should redo the PR to only allow explicit lists as well.

[github-actions]

❌ VyOS CLI smoketests failed!

[dmbaturin]

The smoketest failure is unrelated to the change and is safe to ignore.

[dmbaturin]

@Mergifyio backport circinus

[mergify]

backport circinus

✅ Backports have been created

• #3758 ssh: T5878: Allow changing the PubkeyAcceptedAlgorithms option (backport #3721) has been created for branch circinus

[dmbaturin]

@Mergifyio backport sagitta

[mergify]

backport sagitta

✅ Backports have been created

• #3759 ssh: T5878: Allow changing the PubkeyAcceptedAlgorithms option (backport #3721) has been created for branch sagitta