Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T751: Remove ids suricata #3723

Merged
merged 1 commit into from
Jun 26, 2024
Merged

T751: Remove ids suricata #3723

merged 1 commit into from
Jun 26, 2024

Conversation

sever-sever
Copy link
Member

@sever-sever sever-sever commented Jun 26, 2024

Change Summary

Remove suricata from the circinus branch.
We should refrain from nontested and possible broken features in this branch.
After this commit it is a big chance that suricata does not work at all as expected.
Let's delete it and leave it for the "current".

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Delete suricata

Related Task(s)

Related PR(s)

vyos/vyos-build#676

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@sever-sever sever-sever requested a review from a team as a code owner June 26, 2024 13:33
@sever-sever sever-sever requested review from dmbaturin, sarthurdev, zdc, jestabro, c-po and fett0 and removed request for a team June 26, 2024 13:33
Copy link

github-actions bot commented Jun 26, 2024

👍
No issues in PR Title / Commit Title

Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To anyone in the community wondering: we'll reinstate IDS in the future 1.5 LTS branch as soon as it gets enough testing in the rolling release from us and the community to be certain that a) its design will not need big changes b) it's stable enough for LTS.

For now, let's keep testing and improving it in current.

@dmbaturin dmbaturin merged commit 7f08f1f into vyos:circinus Jun 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants