T6510: smoketest: generell improvement task for the smoketesting platform #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-po
requested review from
dmbaturin,
sarthurdev,
zdc,
jestabro,
sever-sever and
nicolas-fort
sever-sever
approved these changes
Jun 26, 2024
11 tasks
11 tasks
c-po
force-pushed
the
T6510-smoketesting
branch
4 times, most recently
from
bc9ebc7
to
b0c8ae3
Compare
For every configuration that is tested from smoketest/configs, there must be a matching smoketest/config-tests file that has all the `set` commands after the migration. Example of missing testcases: vyos@vyos:~$ /usr/bin/vyos-configtest Generating tests Loaded migration result test for config "basic-api-service" Loaded migration result test for config "basic-vyos" Missing migration result test for config "bgp-azure-ipsec-gateway" ... aborted
Validate if the migrators performed correctly by comparing it to a known good result file containing all the required `set` commands
Rather then waiting for a fully assembled ISO image to validate if there is no incompatibility with vyos-configd - like more then one instance of Config(), make this a build time test case for "make test"
Now that there is a build time validation that Config() is not instantiated twice in a config mode script, and also as there are no more direct calls on the my_set and my_delete binary, we can auto generate the list of helpers run by vyos-configd.
Tests must run supervisioned by unittest framework and should not be executed manually
jestabro
approved these changes
Jun 26, 2024
|
❌ VyOS CLI smoketests failed! |
This was referenced Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Smoketest platform
Proposed changes
How to test
Smoketest result
Checklist: