flow-accounting: T3132: fix egress iptables chain #864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Use the right iptables chain for egress flow sampling.
Types of changes
Related Task(s)
Component(s) name
flow-accounting
Proposed changes
Use the right iptables chain for egress flow sampling. Used POSTROUTING, which indeed includes packets created by local processes. Those packets shouldn't be sampled as also done by ingress flow sampling.
This fix also should be cherry-picked in to the current branch.
Please see the comments on the linked task for the problem.
How to test
I've tested it on my lab router. After i applied the proposed change, the samples with macaddress 00:00:00:00:00:00 displayed by
show flow-accounting
disappeared. Same i can confirm with my sFlow collector.Checklist: