Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow-accounting: T3132: fix egress iptables chain #864

Merged
merged 1 commit into from Jun 4, 2021

Conversation

jpbede
Copy link
Contributor

@jpbede jpbede commented Jun 3, 2021

Change Summary

Use the right iptables chain for egress flow sampling.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

flow-accounting

Proposed changes

Use the right iptables chain for egress flow sampling. Used POSTROUTING, which indeed includes packets created by local processes. Those packets shouldn't be sampled as also done by ingress flow sampling.

This fix also should be cherry-picked in to the current branch.

Please see the comments on the linked task for the problem.

How to test

I've tested it on my lab router. After i applied the proposed change, the samples with macaddress 00:00:00:00:00:00 displayed by show flow-accounting disappeared. Same i can confirm with my sFlow collector.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po merged commit e0c86b9 into vyos:equuleus Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants