Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T3491 - Switch kernel to 1000hz #162

Closed
wants to merge 1 commit into from
Closed

T3491 - Switch kernel to 1000hz #162

wants to merge 1 commit into from

Conversation

xrobau
Copy link
Contributor

@xrobau xrobau commented Apr 22, 2021

Signed-Off-By: Rob Thomas xrobau@gmail.com

Change Summary

Change kernel HZ from 250 to 1000

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

T3491

Component(s) name

kernel

Proposed changes

Switch kernel frequency to 1000hz from 250hz, as 250hz was a holdover from the P4-ish era. This allows much better throughput and PPS, and also aligns us with most other distros HZ settings.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Signed-Off-By: Rob Thomas <xrobau@gmail.com>
Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xrobau,

this is the same as #161. Please ensure your commit has a valid headline. I took to opportunity to alter the headlines from #161 to match our CONTRIBUTING guidelines. It is also always a good idea to check a files history what other maintainers used as the commit headline.

This is nothing to make your life harder, this is to make our life easier in the future when we revise changes why certain things became as they are.

@xrobau
Copy link
Contributor Author

xrobau commented Apr 23, 2021

Well that didn't work well. How about this?
image

@c-po
Copy link
Member

c-po commented Apr 23, 2021

LGTM

My comment is not about the change itself, it is about the formal process of using a good commit message which helps us in the future. Can you please reword it?

@c-po
Copy link
Member

c-po commented May 1, 2021

Implemented via a1c4e49

@c-po c-po closed this May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants