Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pmacct: T5618: Added build rules for custom pmacct package #428

Merged
merged 1 commit into from Sep 28, 2023
Merged

pmacct: T5618: Added build rules for custom pmacct package #428

merged 1 commit into from Sep 28, 2023

Conversation

zdc
Copy link
Contributor

@zdc zdc commented Sep 28, 2023

Change Summary

Added build rules for custom pmacct package

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

pmacct

Proposed changes

The current version of pmacct in Debian (1.7.7-1) contains the bug which leads to a crash when IMT is enabled and ICMP traffic is forwarded through a router.

This PR adds our build with an extra patch, which solves the problem: pmacct/pmacct@73af954

How to test

Configuration for tests:

set system flow-accounting interface 'eth0'
set system flow-accounting netflow server 192.168.139.1 port '2055'

Without the patched pmacct version, as soon as eth0 receives an ICMP packet pmacct will crash.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@zdc
pmacct: T5618: Added build rules for custom pmacct package
d5f6445 
The current version of pmacct in Debian (`1.7.7-1`) contains the bug which leads
to a crash when IMT is enabled and ICMP traffic is forwarded through a router.

This commit adds our build with an extra patch, which solves the problem:
pmacct/pmacct@73af954
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, jestabro, sever-sever and c-po and removed request for a team September 28, 2023 16:56
@c-po c-po merged commit ad85335 into vyos:current Sep 28, 2023
3 of 4 checks passed
@c-po c-po mentioned this pull request Sep 28, 2023
Merged
11 tasks
c-po added a commit that referenced this pull request Sep 30, 2023
@c-po
Merge pull request #429 from c-po/pmacct-sagitta
184429e 
pmacct: T5618: Added build rules for custom pmacct package (backport #428)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin was automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro was automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever was automatically assigned from vyos/reviewers

Assignees

@zdc zdc

Labels
None yet
Milestone
No milestone
2 participants
@zdc @c-po