T5589: Nonstripped binaries exists in VyOS

[Apachez-]

Change Summary

Add capability to exclude files from being stripped by data/live-build-config/hooks/live/99-strip-symbols.chroot.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

• https://vyos.dev/T5589

Follow up on:

• T5589: Nonstripped binaries exists in VyOS #426

Component(s) name

build

Proposed changes

Turns out that package binutils contains libraries who have not been stripped according to Debian policy:

Parse dir (strip-unneeded: /usr/lib/x86_64-linux-gnu
Strip file (strip-unneeded): /usr/lib/x86_64-linux-gnu/libsframe.so.0.0.0
/root/99-strip-symbols.chroot: line 53: 52424 Segmentation fault      (core dumped) ${STRIPCMD_UNNEEDED} ${FILE}
Strip file (strip-unneeded): /usr/lib/x86_64-linux-gnu/libusdm_drv_s.so
Parse dir (strip-unneeded: /usr/lib32

This commit add variable STRIP_EXCLUDE to exclude files from being stripped by the 99-strip-symbols.chroot script.

Currently the files to be excluded are added dynamically to be compatible with future updates of the libbinutils package (installed by package binutils):

STRIP_EXCLUDE=`dpkg-query -L libbinutils | grep '.so'`

How to test

During build of ISO the log output should look something like this (good):

Exclude files: /usr/lib/x86_64-linux-gnu/libbfd-2.40-system.so
/usr/lib/x86_64-linux-gnu/libopcodes-2.40-system.so
/usr/lib/x86_64-linux-gnu/libsframe.so.0.0.0
/usr/lib/x86_64-linux-gnu/libsframe.so.0
Parse dir (strip-debug): /usr/lib/modules
...
Parse dir (strip-unneeded: /usr/lib/x86_64-linux-gnu
Strip file (strip-unneeded): /usr/lib/x86_64-linux-gnu/libusdm_drv_s.so
Parse dir (strip-unneeded: /usr/lib32

rather than this (bad):

Parse dir (strip-unneeded: /usr/lib/x86_64-linux-gnu
Strip file (strip-unneeded): /usr/lib/x86_64-linux-gnu/libsframe.so.0.0.0
/root/99-strip-symbols.chroot: line 53: 52424 Segmentation fault      (core dumped) ${STRIPCMD_UNNEEDED} ${FILE}
Strip file (strip-unneeded): /usr/lib/x86_64-linux-gnu/libusdm_drv_s.so
Parse dir (strip-unneeded: /usr/lib32

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly