Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T6238: Check pull request title action requires the python script #560

Merged
merged 1 commit into from Apr 13, 2024
Merged

T6238: Check pull request title action requires the python script #560

merged 1 commit into from Apr 13, 2024

Conversation

sever-sever
Copy link
Member

@sever-sever sever-sever commented Apr 13, 2024 •
edited

Change Summary

The check-pr-title-and-commit-messages.py that is used for the action does not exist.
Add this script.

Check pull request title

Run ./scripts/check-pr-title-and-commit-messages.py 'https://api.github.com/repos/vyos/vyos-build/pulls/550'
/home/runner/work/_temp/a3bcd9a8-9e2b-44d8-8929-b6e0b23efb9f.sh: line 1: ./scripts/check-pr-title-and-commit-messages.py: No such file or directory

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): add python3 script

Related Task(s)

Component(s) name

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@sever-sever
T6238: Check poll request title action requires the python script
06d12a5 
The `check-pr-title-and-commit-messages.py` that used for the action
is not exists.
Add this script.
@vyosbot vyosbot requested review from a team and dmbaturin and removed request for a team April 13, 2024 08:22
@sever-sever sever-sever changed the title T6238: Check poll request title action requires the python script T6238: Check pull request title action requires the python script Apr 13, 2024
@c-po
Copy link
Member

c-po commented Apr 13, 2024

@Mergifyio backport sagitta

@c-po c-po merged commit 8c6e479 into vyos:current Apr 13, 2024
5 checks passed
@mergify Mergify
Copy link

mergify bot commented Apr 13, 2024 •
edited

backport sagitta

✅ Backports have been created

@mergify mergify bot mentioned this pull request Apr 13, 2024
Merged
11 tasks
c-po added a commit that referenced this pull request Apr 13, 2024
@c-po
Merge pull request #563 from vyos/mergify/bp/sagitta/pr-560
25d01cf 
T6238: Check pull request title action requires the python script (backport #560)
@sever-sever sever-sever deleted the T6238 branch April 16, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin was automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro was automatically assigned from vyos/reviewers

Assignees

@sever-sever sever-sever

Labels
current
Milestone
No milestone
2 participants
@sever-sever @c-po