Fix issue with ovftool signing command (T2239) #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signing key can be submitted by putting key at a fixed location (key/privatekey.pem) or by putting the key location in environment variable PRIVATE_KEY_PATH. The script checks for either of those possibilities. ovftool command was incorrectly using the PRIVATE_KEY_PATH variable even when the key file was dropped in the prescribed location.
kroy-the-rabbit
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
Looks good to me. Looking at the context that creates that variable, this was a bug which this should correct.
Definitely want to add T2239 to the title of this PR though.
chrismarget
changed the title
|
Task ID should be added to commit, too as written in our guides: https://docs.vyos.io/en/latest/contributing/development.html#submit-a-patch Modifying headline now with Squash Merge |
|
Thank you, Christian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a bug in the
build-vmware-imagescript.Without this fix, the script checks for the presence of a signing key at
a prescribed location, but then ignores that key when creating the
signed OVA file.
Signing key can be submitted by putting key at a fixed location
(key/privatekey.pem) or by putting the key location in environment
variable PRIVATE_KEY_PATH. The script checks for either of those
possibilities.
ovftool command was incorrectly using the PRIVATE_KEY_PATH variable
even when the key file was dropped in the prescribed location.