Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BGP Password fix #305

Merged
merged 2 commits into from
Mar 28, 2023
Merged

BGP Password fix #305

merged 2 commits into from
Mar 28, 2023

Conversation

rfranks-securenet
Copy link
Contributor

Updated command to use neighbor.password rather than neighbor.address

SUMMARY

Fixes #304

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

bgp_global

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/3f1d6f15fbf04346b0d9b65f09a46ca2

✔️ ansible-galaxy-importer SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 8m 28s
❌ ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0005814635 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0005814636 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0005814637 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0005814638 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0005814639 failed in 0s (non-voting)
❌ ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0005814640 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0005814641 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0005814642 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0005814643 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0005814644 failed in 0s
✔️ ansible-tox-linters SUCCESS in 10m 21s

Qalthos
Qalthos suggested changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@Qalthos Qalthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog fragment for this, please?

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/505421b6fc1b475c91da51973cceddfa

✔️ ansible-galaxy-importer SUCCESS in 4m 38s
✔️ build-ansible-collection SUCCESS in 8m 34s
❌ ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0005830760 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0005830761 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0005830762 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0005830763 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0005830764 failed in 0s (non-voting)
❌ ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0005830765 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0005830766 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0005830767 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0005830768 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0005830769 failed in 0s
✔️ ansible-tox-linters SUCCESS in 10m 32s

@rfranks-securenet @Qalthos
BGP Password fix
88bbd3c 
Updated command to use neighbor.password rather than neighbor.address
@rfranks-securenet @Qalthos
Added changelog fragment
110a162
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/63f63174162a41f98c56437f4dc4f847

✔️ ansible-galaxy-importer SUCCESS in 4m 40s
✔️ build-ansible-collection SUCCESS in 8m 46s
❌ ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0005831753 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0005831754 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0005831755 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0005831756 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0005831757 failed in 0s (non-voting)
❌ ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0005831758 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0005831759 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0005831760 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0005831761 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0005831762 failed in 0s
✔️ ansible-tox-linters SUCCESS in 11m 30s

@Qalthos Qalthos enabled auto-merge (squash) March 28, 2023 20:06
@Qalthos Qalthos disabled auto-merge March 28, 2023 20:06
@Qalthos Qalthos merged commit 4a4b348 into vyos:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qalthos Qalthos Qalthos approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BGP neighbor password set incorrectly
2 participants
@rfranks-securenet @Qalthos