fix return out of loop

vyperlang · Feb 23, 2022 · 86220cf · 86220cf
1 parent 9abf013
commit 86220cf
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/vyper/codegen/return_.py b/vyper/codegen/return_.py
@@ -40,9 +40,10 @@ def finalize(fill_return_buffer):
             fill_return_buffer, annotation=f"fill return buffer {sig._lll_identifier}"
         )
         cleanup_loops = "cleanup_repeat" if context.forvars else "pass"
+        # NOTE: because stack analysis is incomplete, cleanup_repeat must
+        # come after fill_return_buffer otherwise the stack will break
         return LLLnode.from_list(
-            ["seq", cleanup_loops, fill_return_buffer, jump_to_exit],
-            typ=None,
+            ["seq", fill_return_buffer, cleanup_loops, jump_to_exit],
             pos=_pos,
         )