Skip to content

Commit

Permalink
chore(ci): build binaries on pull requests (#3591)
Browse files Browse the repository at this point in the history
build binaries on all pull requests, to have better oversight over
binary build success
  • Loading branch information
charles-cooper committed Sep 6, 2023
1 parent aca2b4c commit bb6e69a
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build and release artifacts
name: Build artifacts

on:
workflow_dispatch:
Expand All @@ -8,6 +8,7 @@ on:
push:
branches:
- master
pull_request:
release:
types: [published] # releases and pre-releases (release candidates)

Expand Down Expand Up @@ -42,6 +43,7 @@ jobs:
pip install pyinstaller &&
make freeze
- name: Upload Artifact
uses: actions/upload-artifact@v3
with:
Expand Down Expand Up @@ -101,3 +103,13 @@ jobs:
"https://uploads.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets?name=${BIN_NAME}" \
--data-binary "@${BIN_NAME}"
done
# check build success for pull requests
build-success:
if: always()
runs-on: ubuntu-latest
needs: [windows-build, unix-build]
steps:
- name: check that all builds succeeded
if: ${{ contains(needs.*.result, 'failure') }}
run: exit 1

0 comments on commit bb6e69a

Please sign in to comment.