Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addmod / mulmod #1786

Merged
merged 2 commits into from Dec 30, 2019
Merged

addmod / mulmod #1786

merged 2 commits into from Dec 30, 2019

Conversation

@iamdefinitelyahuman
Copy link
Contributor

iamdefinitelyahuman commented Dec 27, 2019

What I did

  • remove overflow checks on uint256_addmod and uint256_mulmod - closes #1689
  • add basic documentation about these methods

How I did it

Mostly I used the delete key.

How to verify it

Run the tests. I modified a couple of test cases to make sure it works.

Cute Animal Picture

image

@fubuloubu fubuloubu merged commit da1e972 into vyperlang:master Dec 30, 2019
7 checks passed
7 checks passed
lint
Details
mypy
Details
py36-core
Details
py37-core
Details
py38-core
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
@iamdefinitelyahuman iamdefinitelyahuman deleted the iamdefinitelyahuman:addmod-mulmod branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.