Modifications to how ABI data types are represented #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
namefield in the ABI when representing tuple types. For inputs, the name is equal to the variable name of the struct. For outputs, the name is"". This is consistent with how Solidity represents tuples."out"to"". Again - this makes the Vyper ABI more consistent with Solidity.This is related to, but does require, #1842. As @michwill pointed out, there is a bug when attempting to import a JSON interface that uses structs. Adding the
"name"field fixes the bug and leads to another conversation: we do not currently support tuple types when importing interfaces. And that will be the subject of another PR :)How I did it
Modifications to
vyper/signatures/function_signature.py. See diff.How to verify it
Run the tests. I updated cases that were failing based on the change.
Cute Animal Picture