New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ir and metadata outputs for vyper-json #2600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine
@@ -121,7 +121,7 @@ def test_source_ids_increment(): | |||
def test_outputs(): | |||
result, _ = compile_from_input_dict(INPUT_JSON) | |||
assert sorted(result.keys()) == ["contracts/bar.vy", "contracts/foo.vy"] | |||
assert sorted(result["contracts/bar.vy"].keys()) == sorted(TRANSLATE_MAP.values()) | |||
assert sorted(result["contracts/bar.vy"].keys()) == sorted(set(TRANSLATE_MAP.values())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there duplicates in TRANSLATE_MAP
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there duplicates in
TRANSLATE_MAP
?
yes - I made ir
and ir_json
both map to ir_json
(it doesn't really make sense to get regular ir
output for vyper-json
when a json version is available).
Codecov Report
@@ Coverage Diff @@
## master #2600 +/- ##
==========================================
+ Coverage 86.61% 86.65% +0.03%
==========================================
Files 91 91
Lines 9430 9433 +3
Branches 2357 2358 +1
==========================================
+ Hits 8168 8174 +6
+ Misses 776 774 -2
+ Partials 486 485 -1
Continue to review full report at Codecov.
|
What I did
How I did it
How to verify it
try
vyper-json
on the followingDescription for the changelog
Cute Animal Picture