allow lists of any type as loop variable #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cooper
changed the title
charles-cooper
force-pushed
the
fix_for_typecheck
branch
from
14df721
to
a2ea1e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2616 +/- ##
==========================================
- Coverage 86.66% 86.53% -0.13%
==========================================
Files 91 92 +1
Lines 9433 9457 +24
Branches 2359 2369 +10
==========================================
+ Hits 8175 8184 +9
- Misses 773 781 +8
- Partials 485 492 +7
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Jan 22, 2022
charles-cooper
commented
Jan 23, 2022
| # override with type inferred at typechecking time | ||
| subtype = BaseType(self.stmt.target._metadata["type"]._id) | ||
| iter_list.typ.subtype = subtype | ||
| target_type = new_type_to_old_type(self.stmt.target._metadata["type"]) |
There was a problem hiding this comment.
Note: investigate why target type != iter.subtype
fubuloubu
approved these changes
Jan 23, 2022
tserg
pushed a commit
to tserg/vyper
that referenced
this pull request
Feb 2, 2022
* allow arbitrary types in loop lists * fix lint * fix mypy * add a test * fix loop target inference * prune some now-invalid tests * fix lint * add a note to revisit type checker * add a nested static array test
tserg
pushed a commit
to tserg/vyper
that referenced
this pull request
Feb 8, 2022
* allow arbitrary types in loop lists * fix lint * fix mypy * add a test * fix loop target inference * prune some now-invalid tests * fix lint * add a note to revisit type checker * add a nested static array test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
allow lists of any type as loop variable
How I did it
added a function
new_type_to_old_typeso that we can use the results of the type checker directly. eventually this can replace the oldparse_typefunction.How to verify it
Description for the changelog
Cute Animal Picture