Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix interface list in for #2699

Merged
merged 3 commits into from
Mar 12, 2022

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Mar 12, 2022

What I did

following code was failing:

xs: MyInterface[N]
for x in self.xs:
    ...

How I did it

there was a missing case in a helper function

How to verify it

see tests

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2022

Codecov Report

Merging #2699 (9a78cff) into master (d4b1e3f) will decrease coverage by 0.84%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2699      +/-   ##
==========================================
- Coverage   86.54%   85.69%   -0.85%     
==========================================
  Files          91       91              
  Lines        9849     9852       +3     
  Branches     2479     2480       +1     
==========================================
- Hits         8524     8443      -81     
- Misses        829      905      +76     
- Partials      496      504       +8     
Impacted Files Coverage Δ
vyper/codegen/types/convert.py 87.87% <100.00%> (+0.78%) ⬆️
vyper/semantics/types/__init__.py 100.00% <100.00%> (ø)
vyper/builtin_functions/functions.py 82.28% <0.00%> (-6.09%) ⬇️
vyper/utils.py 81.16% <0.00%> (-4.55%) ⬇️
vyper/semantics/types/value/numeric.py 83.80% <0.00%> (-3.81%) ⬇️
vyper/ast/nodes.py 92.49% <0.00%> (-1.65%) ⬇️
vyper/codegen/expr.py 78.17% <0.00%> (-1.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b1e3f...9a78cff. Read the comment docs.

@charles-cooper charles-cooper enabled auto-merge (squash) March 12, 2022 16:14
@charles-cooper charles-cooper merged commit cfe26e1 into vyperlang:master Mar 12, 2022
@charles-cooper charles-cooper deleted the fix_empty_interface branch March 12, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants