add print builtin #2818
Merged
add print builtin #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2818 +/- ##
===========================================
- Coverage 87.47% 57.22% -30.25%
===========================================
Files 94 94
Lines 10003 10034 +31
Branches 2480 2438 -42
===========================================
- Hits 8750 5742 -3008
- Misses 785 3686 +2901
- Partials 468 606 +138
Continue to review full report at Codecov.
|
charles-cooper
force-pushed
the
print_builtin
branch
from
70e04da
to
b312046
Compare
equivalent of nomic's console.log
charles-cooper
force-pushed
the
print_builtin
branch
from
b312046
to
c27031f
Compare
fubuloubu
approved these changes
Apr 20, 2022
| args_as_tuple = IRnode.from_list(["multi"] + [x for x in args], typ=args_tuple_t) | ||
| args_abi_t = args_tuple_t.abi_type | ||
| # create a signature like "log(uint256)" | ||
| sig = "log" + "(" + ",".join([arg.typ.abi_type.selector_name() for arg in args]) + ")" |
There was a problem hiding this comment.
Should this be log (built in keyword) or should it be print?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
equivalent of nomic's console.log
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture