Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cbor length metadata #3010

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Jul 29, 2022

so disassemblers/analyzers can reliably detect where the code ends and
the CBOR metadata starts

What I did

fix #3009

How I did it

How to verify it

compile a vyper contract and inspect last 13 bytes

Commit message

add binary encoded length to the end of the CBOR metadata so
disassemblers can reliably detect where code ends and metadata starts

Description for the changelog

add length to CBOR metadata so bytecode analysis can reliably demarcate it

Cute Animal Picture

image

so disassemblers/analyzers can reliably detect where the code ends and
the CBOR metadata starts
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #3010 (1aff960) into master (f31f0ec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3010   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files          97       97           
  Lines       10919    10920    +1     
  Branches     2583     2583           
=======================================
+ Hits         9641     9642    +1     
  Misses        830      830           
  Partials      448      448           
Impacted Files Coverage Δ
vyper/ir/compile_ir.py 93.71% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@charles-cooper charles-cooper enabled auto-merge (squash) July 29, 2022 13:32
@charles-cooper charles-cooper merged commit b096dbd into vyperlang:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CBOR section at end should include length indicator like in Solidity
3 participants