Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in expr when list members are vars #3035

Merged
merged 3 commits into from
Aug 6, 2022

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Aug 6, 2022

What I did

fix #3034

How I did it

dereference pointers properly

How to verify it

Commit message

fix a regression introduced in 2db84a90cd. when the members of a list
literal are not themselves literals, they need to be dereferenced.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2022

Codecov Report

Merging #3035 (800ebaf) into master (7bcfed1) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #3035      +/-   ##
==========================================
- Coverage   88.34%   88.34%   -0.01%     
==========================================
  Files          97       97              
  Lines       10961    10963       +2     
  Branches     2589     2590       +1     
==========================================
+ Hits         9684     9685       +1     
- Misses        829      830       +1     
  Partials      448      448              
Impacted Files Coverage Δ
vyper/codegen/expr.py 85.23% <75.00%> (-0.18%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@charles-cooper charles-cooper enabled auto-merge (squash) August 6, 2022 21:05
@charles-cooper charles-cooper merged commit ec3e588 into vyperlang:master Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error with comparisons with the in statement with version v.0.3.5
3 participants