feat: make send() gas stipend configurable #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3158 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 85 85
Lines 10758 10760 +2
Branches 2286 2286
=======================================
+ Hits 9523 9525 +2
Misses 787 787
Partials 448 448
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thanks! working on test |
|
impl looks good. please add docs and tests, fix lint and should be good to merge |
Also updated type of 'gas' in KwargSettings() to reflect Type refactor
emc415
force-pushed
the
feat/send_gas_stipend
branch
from
db34883
to
ec77d49
Compare
charles-cooper
approved these changes
Dec 6, 2022
took out unnecessary test |
|
lgtm, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
added gas= kwarg to send() to handle #3060
How I did it
added gas= kwarg to built-in send() function and logic to handle the output when gas is passed as a kwarg
How to verify it
Commit message
make send() gas stipend configurable
Description for the changelog
Cute Animal Picture