-
-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add getters for public constants and immutables to self
namespace
#3334
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3334 +/- ##
==========================================
- Coverage 88.93% 88.87% -0.06%
==========================================
Files 84 84
Lines 10606 10606
Branches 2215 2214 -1
==========================================
- Hits 9432 9426 -6
- Misses 768 777 +9
+ Partials 406 403 -3
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
looks good, thanks! |
🐐ed 🙏 Thank you for such quick fix. @charles-cooper how often are releases cut these days (wondering when we would expect to see this in a release cut for pulling into our dev setup)? |
Planning a release in a few weeks |
Amazing! 🙏 |
What I did
Fix #3329.
Getters for public constants and immutables were not added to the
self
namespace, causing validation of implementing an interface to fail.How I did it
Add the getters to namespace
How to verify it
See tests
Commit message
Description for the changelog
Add getters for public constants and immutables to
self
namespaceCute Animal Picture