Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add getters for public constants and immutables to self namespace #3334

Merged
merged 8 commits into from
Apr 7, 2023

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Apr 5, 2023

What I did

Fix #3329.

Getters for public constants and immutables were not added to the self namespace, causing validation of implementing an interface to fail.

How I did it

Add the getters to namespace

How to verify it

See tests

Commit message

fix: add getters for public constants and immutables to `self` namespace

Description for the changelog

Add getters for public constants and immutables to self namespace

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Merging #3334 (d907753) into master (a4c2449) will decrease coverage by 0.06%.
The diff coverage is 76.92%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3334      +/-   ##
==========================================
- Coverage   88.93%   88.87%   -0.06%     
==========================================
  Files          84       84              
  Lines       10606    10606              
  Branches     2215     2214       -1     
==========================================
- Hits         9432     9426       -6     
- Misses        768      777       +9     
+ Partials      406      403       -3     
Impacted Files Coverage Δ
vyper/semantics/analysis/module.py 86.56% <76.92%> (+0.27%) ⬆️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tserg tserg marked this pull request as ready for review April 5, 2023 07:42
@charles-cooper
Copy link
Member

looks good, thanks!

@charles-cooper charles-cooper enabled auto-merge (squash) April 7, 2023 05:18
@charles-cooper charles-cooper merged commit 026f85f into vyperlang:master Apr 7, 2023
70 checks passed
@tserg tserg deleted the fix/implements branch April 7, 2023 07:59
@jakerockland
Copy link
Contributor

🐐ed 🙏

Thank you for such quick fix.

@charles-cooper how often are releases cut these days (wondering when we would expect to see this in a release cut for pulling into our dev setup)?

@charles-cooper
Copy link
Member

Planning a release in a few weeks

@jakerockland
Copy link
Contributor

Planning a release in a few weeks

Amazing! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getters for variables that are both immutable and public are not interface-conforming
4 participants