feat: let params of internal functions be mutable

[tserg]

What I did

Fix #3449.

How I did it

Update attributes in VarInfo and VariableRecord.

How to verify it

See tests.

Commit message

feat: let params of internal functions be mutable

This PR sets the data location of internal functions' params to
memory. Additionally, they are now mutable unlike an external
function's params.

Description for the changelog

Let params of internal functions be mutable.

Cute Animal Picture

[codecov-commenter]

Codecov Report

Merging #3473 (f7a7472) into master (e97e9f2) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3473      +/-   ##
==========================================
+ Coverage   89.30%   89.35%   +0.05%     
==========================================
  Files          84       84              
  Lines       10792    10777      -15     
  Branches     2461     2456       -5     
==========================================
- Hits         9638     9630       -8     
+ Misses        756      751       -5     
+ Partials      398      396       -2     

Impacted Files	Coverage Δ
.../codegen/function_definitions/internal_function.py	100.00% <100.00%> (ø)
vyper/semantics/analysis/local.py	91.97% <100.00%> (+0.02%)	⬆️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[charles-cooper]

please add some tests with complex types: static arrays, dynarrays and structs.

[charles-cooper]

i don't really like repeating branches in general. here i think we can get rid of it with either squashing all into a single ternary like so

Suggested change

	# allow internal function params to be mutable
	location = DataLocation.MEMORY if self.func.is_internal else DataLocation.CALLDATA
	is_immutable = False if self.func.is_internal else True
	# allow internal function params to be mutable
	location, is_immutable = (DataLocation.MEMORY, False) if self.func.is_internal else (DataLocation.CALLDATA, True)

or two assignments per branch

Suggested change

	# allow internal function params to be mutable
	location = DataLocation.MEMORY if self.func.is_internal else DataLocation.CALLDATA
	is_immutable = False if self.func.is_internal else True
	if self.func.is_internal:
	location = DataLocation.MEMORY
	is_immutable = False
	else:
	location = DataLocation.CALLDATA
	is_immutable = True

[charles-cooper]

can you also add tests which check that struct fields / array members are mutable?

[charles-cooper]

lgtm - thanks!