Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: parametrize CI over EVM versions #3842

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Mar 7, 2024

What I did

How I did it

How to verify it

Commit message

this commit parametrizes the github actions rules over evm versions. it
uses the github actions matrix syntax, but because github actions
apparently does not allow additional matrices in the `include` rule, the
additional rules must be written out manually.

misc:
- fix for py-evm logger name
- refactor tests which were previously manually parametrized over evm
  versions
- remove the tox environment for running tests in favor of the gh
  actions script

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.21%. Comparing base (a9ee641) to head (e2d7e88).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3842      +/-   ##
==========================================
+ Coverage   86.19%   86.21%   +0.02%     
==========================================
  Files          92       92              
  Lines       14013    14013              
  Branches     3078     3078              
==========================================
+ Hits        12079    12082       +3     
+ Misses       1497     1493       -4     
- Partials      437      438       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper marked this pull request as ready for review March 14, 2024 01:57
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One fix suggested, also the two CodeQL notes about importing a constant can be dismissed?

@charles-cooper
Copy link
Member Author

charles-cooper commented Mar 15, 2024

One fix suggested, also the two CodeQL notes about importing a constant can be dismissed?

one of the codeql notes (https://github.com/vyperlang/vyper/security/code-scanning/1326):

vyper/compiler/init.py:11

from vyper.evm.opcodes import DEFAULT_EVM_VERSION, anchor_evm_version
Importing the value of 'DEFAULT_EVM_VERSION' from  means that any change made to  will be not be observed locally.

it's kind of interesting, because DEFAULT_EVM_VERSION is actually unused, but it was not picked up by any linter before. anyway, i'll remove it.

@charles-cooper charles-cooper enabled auto-merge (squash) March 15, 2024 01:56
@charles-cooper charles-cooper merged commit 73925d2 into vyperlang:master Mar 15, 2024
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants