chore[test]: update hexbytes version and tests #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: pypi/hexbytes@0.3.1, pypi/hexbytes@0.3.1 |
DanielSchiavini
changed the title
DanielSchiavini
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3904 +/- ##
==========================================
- Coverage 90.89% 89.14% -1.76%
==========================================
Files 95 95
Lines 14388 14388
Branches 3186 3186
==========================================
- Hits 13078 12826 -252
- Misses 908 1112 +204
- Partials 402 450 +48 ☔ View full report in Codecov by Sentry. |
tests/functional/codegen/calling_convention/test_external_contract_calls.py
Outdated
Show resolved
Hide resolved
tests/functional/codegen/calling_convention/test_external_contract_calls.py
Outdated
Show resolved
Hide resolved
| @@ -1,6 +1,10 @@ | |||
| from vyper.utils import hex_to_int | |||
|
|
|||
|
|
|||
| def test_sanity(keccak): | |||
There was a problem hiding this comment.
let's move this to tests/unit (maybe tests/unit/utils/test_keccak256.py)
| @@ -1,6 +1,10 @@ | |||
| from vyper.utils import hex_to_int | |||
|
|
|||
|
|
|||
| def test_sanity(keccak): | |||
| assert keccak(b"").hex() == "c5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470" | |||
There was a problem hiding this comment.
add comment - sha3 vs keccak
Suggested change
| assert keccak(b"").hex() == "c5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470" | |
| # ensure keccak is keccak256, not sha3 | |
| # https://ethereum.stackexchange.com/a/107985 | |
| assert keccak(b"").hex() == "c5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470" |
tests/functional/codegen/calling_convention/test_external_contract_calls.py
Show resolved
Hide resolved
| @@ -41,7 +41,7 @@ def foo(bar: uint256) -> Bytes[36]: | |||
| contract = get_contract(code) | |||
|
|
|||
| # 2fbebd38000000000000000000000000000000000000000000000000000000000000002a | |||
| method_id = keccak(text="foo(uint256)").hex()[2:10] # 2fbebd38 | |||
| method_id = keccak(b"foo(uint256)").hex()[:8] # 2fbebd38 | |||
There was a problem hiding this comment.
i guess we can use the method_id() util here to be consistent with the test_variable_assignment above
charles-cooper
approved these changes
Apr 4, 2024
electriclilies
pushed a commit
to electriclilies/vyper
that referenced
this pull request
Apr 27, 2024
update some tests after they were broken by an upstream update. `eth-account` got bumped from 0.11.0 to 0.12.0, which in turn bumped `hexbytes` to 1.2.0. `hexbytes` 1.0.0 had a (long overdue) breaking change, which was to change the `.hex()` method to not prepend "0x". this commit updates our tests accordingly, and does a bit of refactoring in some places to use `bytes` directly instead of `HexBytes` (including that the `keccak` fixture is changed to use vyper.utils.keccak256 instead of the one provided by web3, which returns `HexBytes`). it also cleans up some manual method id calculations with the utility functions. --------- Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Update hexbytes version
Cute Animal Picture