Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[tool]: add help text for hex-ir CLI flag #3942

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

antazoey
Copy link
Contributor

What I did

I noticed --hex-ir was missing a help.
Simple PR adds one.

side nit: I notice inconsistencies with CLI help texts... Some start with capital letter, some have periods at the end, etc.

How I did it

help=

How to verify it

vyper --help

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

woof

@charles-cooper charles-cooper changed the title chore: add help text for hex-ir flag chore[tool]: add help text for hex-ir flag Apr 12, 2024
@charles-cooper charles-cooper changed the title chore[tool]: add help text for hex-ir flag chore[tool]: add help text for hex-ir CLI flag Apr 12, 2024
@charles-cooper
Copy link
Member

seems fine. please fix lint!

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.69%. Comparing base (cb94068) to head (196871c).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3942      +/-   ##
==========================================
- Coverage   90.85%   90.69%   -0.16%     
==========================================
  Files          95       95              
  Lines       14416    14449      +33     
  Branches     3192     3204      +12     
==========================================
+ Hits        13097    13105       +8     
- Misses        913      928      +15     
- Partials      406      416      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper merged commit 39b46ca into vyperlang:master Apr 15, 2024
148 checks passed
@antazoey antazoey deleted the chore/add-hex-ir-help branch April 15, 2024 13:28
electriclilies pushed a commit to electriclilies/vyper that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants