Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[lang]: fix pow folding when args are not literals #3949

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Apr 14, 2024

What I did

fix #3948

How I did it

How to verify it

Commit message

this commit fixes folding of the `**` operator when the arguments are
constants, but not literals.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

this commit fixes folding of the `**` operator when the arguments are
constants, but not literals.
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.85%. Comparing base (074073f) to head (001e7dd).

Files Patch % Lines
vyper/semantics/types/primitives.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3949      +/-   ##
==========================================
- Coverage   90.87%   90.85%   -0.03%     
==========================================
  Files          95       95              
  Lines       14449    14449              
  Branches     3204     3204              
==========================================
- Hits        13131    13127       -4     
- Misses        910      914       +4     
  Partials      408      408              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper changed the title fix[lang]: fix pow folding when args are not literals fix[lang]: fix pow folding when args are not literals Apr 15, 2024
@charles-cooper charles-cooper merged commit e1adb7b into vyperlang:master Apr 15, 2024
150 checks passed
@charles-cooper charles-cooper deleted the fix/lang/pow_folding branch April 15, 2024 19:13
electriclilies pushed a commit to electriclilies/vyper that referenced this pull request Apr 27, 2024
this commit fixes folding of the `**` operator when the arguments are
constants, but not literals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

constant folding fails for constant exponentiation
4 participants