Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[lang]: exports for inline interfaces #3960

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

What I did

fix for #3959

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 58.45%. Comparing base (e1adb7b) to head (e96b670).
Report is 6 commits behind head on master.

❗ Current head e96b670 differs from pull request most recent head bbe6735. Consider uploading reports for the commit bbe6735 to get more accurate results

Files Patch % Lines
vyper/semantics/analysis/utils.py 20.00% 2 Missing and 2 partials ⚠️
vyper/semantics/types/base.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3960       +/-   ##
===========================================
- Coverage   90.86%   58.45%   -32.41%     
===========================================
  Files          95       95               
  Lines       14454    14458        +4     
  Branches     3205     3207        +2     
===========================================
- Hits        13134     8452     -4682     
- Misses        912     5375     +4463     
- Partials      408      631      +223     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper force-pushed the fix/interface-exports branch 2 times, most recently from 85caf0d to bbe6735 Compare May 1, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants