Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[lang]!: getter types for interfaces #3961

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

What I did

for interface compatibility reasons, apparently InterfaceT reported that its getter signature was AddressT(). this changes the getter signature to the "more correct" InterfaceT. it also relaxes type checking for interfaces, allowing interfaces to be assigned to address in the type system.

fix #3954 (comment)
fix #3701 (comment)

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.82%. Comparing base (7d28a50) to head (c3eef76).
Report is 2 commits behind head on master.

❗ Current head c3eef76 differs from pull request most recent head 342f950. Consider uploading reports for the commit 342f950 to get more accurate results

Files Patch % Lines
vyper/semantics/types/module.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3961       +/-   ##
===========================================
- Coverage   90.81%   58.82%   -31.99%     
===========================================
  Files          98       95        -3     
  Lines       14867    14454      -413     
  Branches     3309     3205      -104     
===========================================
- Hits        13501     8503     -4998     
- Misses        945     5320     +4375     
- Partials      421      631      +210     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implements does not respect public getter of interface type VIP: disallow the use of self as an address
2 participants