chore[ux]: remove deprecated python AST classes #3998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tserg
changed the title
…e/deprec_warnings
…e/deprec_warnings
charles-cooper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Resolves #3970.
How I did it
I think the fix can be limited to updating the handling of docstrings and unary op.
While the NameConstant, Num, Str and Bytes python AST classes are deprecated, they don't raise any warnings, and I think the transformation of the singular python Constant AST node into these equivalent Vyper nodes is still useful. In any case, if we do want to remove the Vyper equivalent of these deprecated classes too, it would probably be worth a PR on its own as the changes are quite extensive (I went down this rabbit hole in a stashed branch).
How to verify it
Commit message
Description for the changelog
Cute Animal Picture