Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[tool]: fix cross-compilation issues, add windows CI #4014

Merged
merged 18 commits into from
May 15, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented May 11, 2024

What I did

How I did it

How to verify it

Commit message

this commit fixes some `InputBundle` bugs on windows due to how
path-manipulation operations are implemented. it also fixes compilation
of cross-OS archives by settling on using posix paths as standard (this
follows the ZIP archive spec, and is explicit in the python stdlib
implementation of zipfile).

this commit also enables a windows job in the CI for tests, to prevent
bugs like these in the future and increase cross-OS coverage.

references:
- https://stackoverflow.com/a/8177003
- https://hg.python.org/cpython/file/2.7/Lib/zipfile.py#l295
- https://hg.python.org/cpython/file/2.7/Lib/zipfile.py#l1046

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 50.29%. Comparing base (c276c94) to head (1afe87b).

❗ Current head 1afe87b differs from pull request most recent head a43d2e8. Consider uploading reports for the commit a43d2e8 to get more accurate results

Files Patch % Lines
vyper/compiler/output_bundle.py 0.00% 7 Missing ⚠️
vyper/cli/vyper_json.py 0.00% 2 Missing ⚠️
vyper/compiler/input_bundle.py 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4014       +/-   ##
===========================================
- Coverage   90.95%   50.29%   -40.67%     
===========================================
  Files         106      106               
  Lines       15280    15282        +2     
  Branches     3365     3365               
===========================================
- Hits        13898     7686     -6212     
- Misses        946     6965     +6019     
- Partials      436      631      +195     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper changed the title [wip] fix testzip() failure on windows fix[tool]: enable CI for windows and fix related issues May 15, 2024
@charles-cooper charles-cooper marked this pull request as ready for review May 15, 2024 02:21
Copy link
Collaborator

@pcaversaccio pcaversaccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and it finally worked 😄
image

@charles-cooper charles-cooper changed the title fix[tool]: enable CI for windows and fix related issues fix[tool]: enable CI for windows and fix cross-compilation issues May 15, 2024
@charles-cooper charles-cooper changed the title fix[tool]: enable CI for windows and fix cross-compilation issues fix[tool]: fix cross-compilation issues, add windows CI May 15, 2024
@charles-cooper charles-cooper merged commit 644ae66 into vyperlang:master May 15, 2024
155 of 156 checks passed
@charles-cooper charles-cooper deleted the fix/manifest branch May 15, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants