Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[codegen]: add back in returndatasize check #4144

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Jun 12, 2024

it's not checked in make_setter when needs_clamp is False

What I did

How I did it

How to verify it

Commit message

add back in `returndatasize` check for external calls in the case
that `make_setter()` is not called (i.e. when `needs_clamp()` is
`True`). the check was removed (i.e. there was a regression) in
21f7172274e

test case and poc contributed by @cyberthirst

---------

Co-authored-by: cyberthirst <cyberthirst.eth@gmail.com>

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

charles-cooper and others added 2 commits June 12, 2024 08:14
it's not checked in `make_setter` when `needs_clamp` is False
contributed by @cyberthirst

---------

Co-authored-by: cyberthirst <cyberthirst.eth@gmail.com>
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.38%. Comparing base (e9e9d78) to head (7653155).

Current head 7653155 differs from pull request most recent head e6cd05e

Please upload reports for the commit e6cd05e to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4144      +/-   ##
==========================================
- Coverage   91.20%   90.38%   -0.82%     
==========================================
  Files         109      109              
  Lines       15568    15552      -16     
  Branches     3417     3415       -2     
==========================================
- Hits        14199    14057     -142     
- Misses        939     1037      +98     
- Partials      430      458      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper marked this pull request as ready for review June 12, 2024 12:39
@charles-cooper charles-cooper changed the title add back in returndatasize check fix[codegen]: add back in returndatasize check Jun 12, 2024
@charles-cooper charles-cooper enabled auto-merge (squash) June 13, 2024 14:44
@charles-cooper charles-cooper enabled auto-merge (squash) June 13, 2024 16:13
@charles-cooper charles-cooper merged commit 44bb281 into vyperlang:master Jun 13, 2024
155 checks passed
@charles-cooper charles-cooper deleted the fix/returndatasize-check branch June 13, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants