New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code clean-up #317

Merged

vyuldashev merged 3 commits into vyuldashev:master from adm-bome:fix/code-cleanup

Mar 29, 2020

Collaborator

adm-bome commented Feb 25, 2020

refactored some duplicated code
altered some logic to get the values from message.
acknowledge message in the tests when done with job.
wrote the tests for the queue arguments.
added exchange/queue delete commands with tests

adm-bome added 3 commits

February 25, 2020 09:04


          Better place to tell rabbitMQ Job has failed.

779090b


          cleanup

a927ba1


          cleanup style (not showing-up in local style test)

7dbaac8

adm-bome requested a review from vyuldashev

February 25, 2020 16:01

vyuldashev merged commit 546d69b into vyuldashev:master

Owner

vyuldashev commented Apr 24, 2020

@adm-bome Can you DM me on twitter or Telegram? Same username.

adm-bome deleted the fix/code-cleanup branch

April 26, 2020 09:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment