Fixed issue with duplicate checker by using array_count_values()
to determine if a node has the same name
#13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @vyuldashev π
Thank you for this great little package, it's helped me massively with a project we've had to built quickly. I ran into a small issue however which was with some of the XML I was processing. One section of the XML had the following child nodes:
I found an issue where the
sameName
variable wouldn't betrue
because of the last<ProductCount>
child node causing theisHomogenous
method to returnfalse
.I have solved this issue by using
array_count_values
which will count up all of the occurrences of each of the duplicated nodes, and when it checks to see if a node already exists, we check the$sameNamesOccurrences
array for duplicates.All tests are passing fine and it seems to work for my solution too. I hope you get a chance to review and potentially accept this PR! π€
Have a great day. βοΈ