Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes.mso300679 broken due to changes rolled out on 2019-10-03 #47

Open
mjpieters opened this issue Oct 3, 2019 · 2 comments
Open

fixes.mso300679 broken due to changes rolled out on 2019-10-03 #47

mjpieters opened this issue Oct 3, 2019 · 2 comments

Comments

@mjpieters
Copy link

Today SE rolled out a change titled "Refactor post validation", causing the following error to appear in the console:

TypeError: StackExchange.postValidation.getSidebarPopupOptions is not a function -1:333:47
    <anonymous> https://stackoverflow.com/users/message/create/-1:333
    jQuery 3
    MarkdownEditor https://cdn.sstatic.net/Js/wmd.en.js?v=c7f5081cdae1:2
    e https://cdn.sstatic.net/Js/wmd.en.js?v=c7f5081cdae1:2
    t https://cdn.sstatic.net/Js/wmd.en.js?v=c7f5081cdae1:3
    n https://cdn.sstatic.net/Js/full.en.js?v=1d06422f5fb7:4

This is from fixes.mso300679:

var options = StackExchange.postValidation.getSidebarPopupOptions();

Unfortunately, this breaks the moderator-only 'contact user privately' feature, so I've had to disable S.O.U.P. altogether. This also breaks the WMD editor elsehwere, just not as completely; the editor is left in an unfinished state without buttons.

@vyznev
Copy link
Owner

vyznev commented Oct 4, 2019

Thanks for the report. I've pushed out a point version (1.56.2 / 1.57.8) that just disables this fix for now. I'll look into making it work with the new post validation code later, possibly this weekend.

@double-beep
Copy link

As a temporary workaround, you can use:

var options = {"position":{"my":"left top","at":"right center"},"css":{"max-width":300,"min-width":300},"closeOthers":false};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants